Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
net/mlx5: fix leak when configured repeatedly
[ upstream commit 6dad8b3 ]

Currently, configuring a mlx device, it will allocate its
own process private in mlx5_proc_priv_init() and only frees
it when closing the device. This will lead to a memory leak,
when a device is configured repeatedly.

For example:
for(...)
do
    rte_eth_dev_configure
    rte_eth_rx_queue_setup
    rte_eth_tx_queue_setup
    rte_eth_dev_start
    rte_eth_dev_stop
done

Fixes: 120dc4a ("net/mlx5: remove device register remap")

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
  • Loading branch information
wyjwang authored and cpaelzer committed Jun 10, 2021
1 parent bb76015 commit 5c78bf8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/net/mlx5/mlx5.c
Expand Up @@ -1255,6 +1255,7 @@ mlx5_proc_priv_init(struct rte_eth_dev *dev)
struct mlx5_proc_priv *ppriv;
size_t ppriv_size;

mlx5_proc_priv_uninit(dev);
/*
* UAR register table follows the process private structure. BlueFlame
* registers for Tx queues are stored in the table.
Expand Down

0 comments on commit 5c78bf8

Please sign in to comment.