Skip to content

Commit

Permalink
test/event_crypto_adapter: fix configuration
Browse files Browse the repository at this point in the history
This patch updates the xform with right configuration.
For session based ops, sym session pool is created with
valid userdata size.

Fixes: 24054e3 ("test/crypto: use separate session mempools")
Cc: stable@dpdk.org

Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
  • Loading branch information
asgujjar authored and akhilnxp committed Oct 14, 2020
1 parent 4868f65 commit 7444937
Showing 1 changed file with 5 additions and 19 deletions.
24 changes: 5 additions & 19 deletions app/test/test_event_crypto_adapter.c
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ test_op_forward_mode(uint8_t session_less)
struct rte_event ev;
uint32_t cap;
int ret;
uint8_t cipher_key[17];

memset(&m_data, 0, sizeof(m_data));

Expand All @@ -183,14 +182,7 @@ test_op_forward_mode(uint8_t session_less)
/* Setup Cipher Parameters */
cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
cipher_xform.next = NULL;

cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;

cipher_xform.cipher.key.data = cipher_key;
cipher_xform.cipher.key.length = 16;
cipher_xform.cipher.iv.offset = IV_OFFSET;
cipher_xform.cipher.iv.length = 16;
cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;

op = rte_crypto_op_alloc(params.op_mpool,
RTE_CRYPTO_OP_TYPE_SYMMETRIC);
Expand Down Expand Up @@ -378,7 +370,6 @@ test_op_new_mode(uint8_t session_less)
struct rte_mbuf *m;
uint32_t cap;
int ret;
uint8_t cipher_key[17];

memset(&m_data, 0, sizeof(m_data));

Expand All @@ -390,14 +381,7 @@ test_op_new_mode(uint8_t session_less)
/* Setup Cipher Parameters */
cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
cipher_xform.next = NULL;

cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;

cipher_xform.cipher.key.data = cipher_key;
cipher_xform.cipher.key.length = 16;
cipher_xform.cipher.iv.offset = IV_OFFSET;
cipher_xform.cipher.iv.length = 16;
cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;

op = rte_crypto_op_alloc(params.op_mpool,
RTE_CRYPTO_OP_TYPE_SYMMETRIC);
Expand Down Expand Up @@ -564,7 +548,9 @@ configure_cryptodev(void)

params.session_mpool = rte_cryptodev_sym_session_pool_create(
"CRYPTO_ADAPTER_SESSION_MP",
MAX_NB_SESSIONS, 0, 0, 0, SOCKET_ID_ANY);
MAX_NB_SESSIONS, 0, 0,
sizeof(union rte_event_crypto_metadata),
SOCKET_ID_ANY);
TEST_ASSERT_NOT_NULL(params.session_mpool,
"session mempool allocation failed\n");

Expand Down

0 comments on commit 7444937

Please sign in to comment.