Skip to content

Commit

Permalink
net/mlx5: reject jump to root table
Browse files Browse the repository at this point in the history
[ upstream commit 87b26522f7ff65375fb1d773a7f93c70bf857b96 ]

Currently root table as destination is not supported.
The jump action which finally be translated to underlying root table in
rdma-core should be rejected.

Fixes: f78f747 ("net/mlx5: allow jump to group lower than current")

Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
  • Loading branch information
jackmin authored and cpaelzer committed Feb 25, 2022
1 parent 9a63217 commit 7e27559
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/net/mlx5/mlx5_flow_dv.c
Expand Up @@ -3487,7 +3487,7 @@ flow_dv_validate_action_jump(const struct rte_flow_action *action,
const struct rte_flow_attr *attributes,
bool external, struct rte_flow_error *error)
{
uint32_t target_group, table;
uint32_t target_group, table = 0;
int ret = 0;

if (action_flags & (MLX5_FLOW_FATE_ACTIONS |
Expand Down Expand Up @@ -3515,6 +3515,10 @@ flow_dv_validate_action_jump(const struct rte_flow_action *action,
RTE_FLOW_ERROR_TYPE_ACTION, NULL,
"target group must be other than"
" the current flow group");
if (table == 0)
return rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ACTION_CONF,
NULL, "root table shouldn't be destination");
return 0;
}

Expand Down

0 comments on commit 7e27559

Please sign in to comment.