Skip to content

Commit

Permalink
net/iavf/base: fix command buffer memory leak
Browse files Browse the repository at this point in the history
Allocated resources were not freed in the event of failure in
iavf_init_asq function. This patch gracefully handles all failures.

Fixes: e5b2a9e ("net/avf/base: add base code for avf PMD")
Cc: stable@dpdk.org

Signed-off-by: Pandi Kumar Maharajan <pandi.maharajan@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Acked-by: Qiming Yang <qiming.yang@intel.com>
  • Loading branch information
qzhan16 authored and Ferruh Yigit committed Jan 17, 2020
1 parent 10ae640 commit 87aca6d
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion drivers/net/iavf/base/iavf_adminq.c
Expand Up @@ -82,6 +82,7 @@ enum iavf_status iavf_alloc_adminq_arq_ring(struct iavf_hw *hw)
**/
void iavf_free_adminq_asq(struct iavf_hw *hw)
{
iavf_free_virt_mem(hw, &hw->aq.asq.cmd_buf);
iavf_free_dma_mem(hw, &hw->aq.asq.desc_buf);
}

Expand Down Expand Up @@ -353,14 +354,18 @@ enum iavf_status iavf_init_asq(struct iavf_hw *hw)
/* initialize base registers */
ret_code = iavf_config_asq_regs(hw);
if (ret_code != IAVF_SUCCESS)
goto init_adminq_free_rings;
goto init_config_regs;

/* success! */
hw->aq.asq.count = hw->aq.num_asq_entries;
goto init_adminq_exit;

init_adminq_free_rings:
iavf_free_adminq_asq(hw);
return ret_code;

init_config_regs:
iavf_free_asq_bufs(hw);

init_adminq_exit:
return ret_code;
Expand Down

0 comments on commit 87aca6d

Please sign in to comment.