Skip to content

Commit

Permalink
net/qede: accept bigger RSS table
Browse files Browse the repository at this point in the history
[ upstream commit 6ceb7ab ]

Some dpdk applications blindly pass fixed side RSS hash tables,
and do not check driver/device capabilities.

Moreover, many other drivers do not do such a strong check as well.

Fix it by making qede accept any size rss_key. For larger key
tables we just crop it with notice trace message.

Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
Acked-by: Rasesh Mody <rmody@marvell.com>
  • Loading branch information
cail authored and cpaelzer committed May 11, 2021
1 parent 2cb101b commit 95c2cf4
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/net/qede/qede_ethdev.c
Expand Up @@ -2049,8 +2049,10 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev,
/* RSS hash key */
if (key) {
if (len > (ECORE_RSS_KEY_SIZE * sizeof(uint32_t))) {
DP_ERR(edev, "RSS key length exceeds limit\n");
return -EINVAL;
len = ECORE_RSS_KEY_SIZE * sizeof(uint32_t);
DP_NOTICE(edev, false,
"RSS key length too big, trimmed to %d\n",
len);
}
DP_INFO(edev, "Applying user supplied hash key\n");
rss_params.update_rss_key = 1;
Expand Down

0 comments on commit 95c2cf4

Please sign in to comment.