Skip to content

Commit

Permalink
net/memif: remove unnecessary Rx interrupt stub
Browse files Browse the repository at this point in the history
[ upstream commit d6dccbd76692c64cff79a821bc73069dc5b043e4 ]

The code in memif driver to stub out rx_irq_enable is unnecessary
and causes different error returns than other drivers.
The core ethdev code will return -ENOTSUP if the driver has
a null rx_queue_intr_enable callback.

Fixes: 09c7e63 ("net/memif: introduce memory interface PMD")

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
  • Loading branch information
shemminger authored and cpaelzer committed Feb 25, 2022
1 parent 2d59bc7 commit c39fd98
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions drivers/net/memif/rte_eth_memif.c
Expand Up @@ -1412,23 +1412,6 @@ memif_stats_reset(struct rte_eth_dev *dev)
return 0;
}

static int
memif_rx_queue_intr_enable(struct rte_eth_dev *dev __rte_unused,
uint16_t qid __rte_unused)
{
MIF_LOG(WARNING, "Interrupt mode not supported.");

return -1;
}

static int
memif_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t qid __rte_unused)
{
struct pmd_internals *pmd __rte_unused = dev->data->dev_private;

return 0;
}

static const struct eth_dev_ops ops = {
.dev_start = memif_dev_start,
.dev_close = memif_dev_close,
Expand All @@ -1438,8 +1421,6 @@ static const struct eth_dev_ops ops = {
.rx_queue_setup = memif_rx_queue_setup,
.rx_queue_release = memif_queue_release,
.tx_queue_release = memif_queue_release,
.rx_queue_intr_enable = memif_rx_queue_intr_enable,
.rx_queue_intr_disable = memif_rx_queue_intr_disable,
.link_update = memif_link_update,
.stats_get = memif_stats_get,
.stats_reset = memif_stats_reset,
Expand Down

0 comments on commit c39fd98

Please sign in to comment.