Skip to content

Commit

Permalink
build: provide suitable error for "both" libraries option
Browse files Browse the repository at this point in the history
[ upstream commit 08895f1 ]

Rather than having the DPDK configuration error out when linking apps
and examples when "both" is select for "default_library" option, we can
detect that setting earlier in the build config and provide a suitable
error message to the user.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Reviewed-by: Andrew Boyer <aboyer@pensando.io>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
  • Loading branch information
bruce-richardson authored and cpaelzer committed Feb 3, 2021
1 parent 60c02f5 commit de0465b
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions config/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -280,3 +280,12 @@ if get_option('b_lto')
add_project_link_arguments('-Wno-lto-type-mismatch', language: 'c')
endif
endif

if get_option('default_library') == 'both'
error( '''
Unsupported value "both" for "default_library" option.
NOTE: DPDK always builds both shared and static libraries. Please set
"default_library" to either "static" or "shared" to select default linkage
for apps and any examples.''')
endif

0 comments on commit de0465b

Please sign in to comment.