Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a branch label to workflow metrics #154

Closed
kjkuan opened this issue Dec 28, 2023 · 2 comments
Closed

Add a branch label to workflow metrics #154

kjkuan opened this issue Dec 28, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kjkuan
Copy link

kjkuan commented Dec 28, 2023

Hi,

Would it make sense to add a branch label to the workflow metrics (workflow_*)?

Our github action workflow works for both PR branches and special environment branches like, master, staging, and prod. Having a branch label in the workflow metrics would help us distinguish different types of workflow metrics when computing statistics about github action workflows.

Thanks

@cpanato
Copy link
Owner

cpanato commented Jan 19, 2024

makes sense, are you willing to add a PR for that?

@cpanato cpanato added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 19, 2024
@kjkuan
Copy link
Author

kjkuan commented Jan 29, 2024

cool, my colleague has started working on it. We'll send a PR once it's ready, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants