Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a branch label to workflow metrics #164

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Conversation

rguliyev
Copy link
Contributor

This will add a branch label to the workflow metrics (workflow_*) as requested in #154

@cpanato
Copy link
Owner

cpanato commented Feb 1, 2024

thanks for the PR, can you please sign the DCO and also need to rebase

@cpanato cpanato self-requested a review February 1, 2024 08:02
@rguliyev rguliyev force-pushed the branch_labels branch 3 times, most recently from bd3ddfa to ab8b9c6 Compare February 2, 2024 03:47
@rguliyev
Copy link
Contributor Author

rguliyev commented Feb 2, 2024

done

@rguliyev rguliyev force-pushed the branch_labels branch 2 times, most recently from 31b257e to 1e8b0a8 Compare February 12, 2024 18:12
@rguliyev rguliyev closed this Feb 12, 2024
@rguliyev rguliyev deleted the branch_labels branch February 12, 2024 18:27
@peterhalasz
Copy link
Contributor

@rguliyev I think there's lots of value in this feature, are you sure you don't want to merge it?

@cpanato
Copy link
Owner

cpanato commented Feb 18, 2024

I think so, do you want to reopen this pr?

@cpanato
Copy link
Owner

cpanato commented Feb 18, 2024

@rguliyev thanks, a rebase will require

Signed-off-by: Rauf Guliyev <rguliyev@yugabyte.com>
@rguliyev
Copy link
Contributor Author

@rguliyev thanks, a rebase will require

done

Copy link
Owner

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@cpanato cpanato merged commit 02cb8bc into cpanato:main Feb 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants