Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GITHUB_WEBHOOK_TOKEN env var example #89

Merged
merged 1 commit into from Apr 25, 2023
Merged

Conversation

lalten
Copy link
Contributor

@lalten lalten commented Apr 19, 2023

As in

githubWebhookToken = kingpin.Flag("gh.github-webhook-token", "GitHub Webhook Token.").Envar("GITHUB_WEBHOOK_TOKEN").Default("").String()

@cpanato
Copy link
Owner

cpanato commented Apr 25, 2023

thanks!
can you sign the DCO?

@lalten lalten force-pushed the patch-1 branch 2 times, most recently from 1335993 to 5c45c30 Compare April 25, 2023 11:18
@lalten
Copy link
Contributor Author

lalten commented Apr 25, 2023

thanks! can you sign the DCO?

signed off. Looks like the check does not rerun automatically though

@lalten lalten force-pushed the patch-1 branch 2 times, most recently from 35ae22d to d6a9595 Compare April 25, 2023 11:21
@lalten
Copy link
Contributor Author

lalten commented Apr 25, 2023

thanks! can you sign the DCO?

signed off. Looks like the check does not rerun automatically though

Got it to work, the check requires the signoff to be with the same email as the commit author, which in this case was the github noreply dummy because I did the change on the web interface directly... What a hassle

Copy link
Owner

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@cpanato cpanato merged commit ce44dea into cpanato:main Apr 25, 2023
4 checks passed
@lalten lalten deleted the patch-1 branch April 25, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants