Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent echoing of service output to systemd journal #88

Closed
sloanebernstein opened this issue Apr 11, 2022 · 1 comment · Fixed by #93
Closed

Prevent echoing of service output to systemd journal #88

sloanebernstein opened this issue Apr 11, 2022 · 1 comment · Fixed by #93
Assignees
@sloanebernstein
Labels
Ready for work

Comments

@sloanebernstein
Copy link
Contributor

#86 removed the tee(1) which had been catching all output. Therefore, the systemd service is now sending all output of the service to the journal, which is redundant and not generally useful.

Consider detecting whether stdout/stderr go to a TTY.
@toddr
Copy link
Member

toddr commented Apr 14, 2022

I'm not sure I agree here. If that's all we want to do, then let's just turn off screen output?

@sloanebernstein sloanebernstein self-assigned this Apr 19, 2022
sloanebernstein added a commit that referenced this issue Apr 19, 2022
@sloanebernstein
Turn off screen appender when run as service
1ed3b06 
Only log to file when elevate-cpanel is passed `--service` argument.

Fixes #88.
@sloanebernstein sloanebernstein mentioned this issue Apr 19, 2022
Merged
@toddr toddr closed this as completed in #93 Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sloanebernstein sloanebernstein

Labels
Ready for work
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Turn off screen appender when run as service cpanel/elevate
2 participants
@toddr @sloanebernstein