Only show files within the directory #118

xsawyerx · 2022-01-31T10:20:55Z

UPDATED

use Test::MockFile ();
use DDP;

my $d1 = Test::MockFile->dir('/foo/bar');
my $d2 = Test::MockFile->dir('/foo');
mkdir $d1->path();
mkdir $d2->path();

my $f = Test::MockFile->file( '/foo/bar/baz', '' );

opendir my $dh, '/foo' or die $!;
my @contents = readdir $dh;
closedir $dh or die $!;

p @contents;

The output is currently:

$>perl -Ilib t/tmp.t 
[
    [0] ".",
    [1] "..",
    [2] "bar",
    [3] "bar/baz"
]

it should be

$>perl -Ilib t/tmp.t 
[
    [0] ".",
    [1] "..",
    [2] "bar",
]

The text was updated successfully, but these errors were encountered:

We would grab all files in the directory recursively, but directory listing should only show the directories inside it, not the files within those directories. In other words: foo/ bar/ baz.txt `readdir($path_to_foo)` should show `bar`, not `bar/baz.txt`. Resolves GH cpanel#118

atoomic · 2022-01-31T16:10:05Z

maybe reverse $d1 and $d2 mkdir order?

We would grab all files in the directory recursively, but directory listing should only show the directories inside it, not the files within those directories. In other words: foo/ bar/ baz.txt `readdir($path_to_foo)` should show `bar`, not `bar/baz.txt`. Resolves GH cpanel#118

We would grab all files in the directory recursively, but directory listing should only show the directories inside it, not the files within those directories. In other words: foo/ bar/ baz.txt `readdir($path_to_foo)` should show `bar`, not `bar/baz.txt`. Resolves GH cpanel#118 Unfortunately, because of our naive structure types (an array of string), we may find both a directory and a file within that directory, so we also need to uniq'ify the results.

We would grab all files in the directory recursively, but directory listing should only show the directories inside it, not the files within those directories. In other words: foo/ bar/ baz.txt `readdir($path_to_foo)` should show `bar`, not `bar/baz.txt`. Resolves GH #118 Unfortunately, because of our naive structure types (an array of string), we may find both a directory and a file within that directory, so we also need to uniq'ify the results.

toddr · 2022-01-31T19:59:35Z

this is working correctly now.

xsawyerx added bug Something isn't working cPanel Test Suite labels Jan 31, 2022

xsawyerx mentioned this issue Jan 31, 2022

Do not get confused by inner directory files: #119

Merged

toddr closed this as completed Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only show files within the directory #118

Only show files within the directory #118

xsawyerx commented Jan 31, 2022 •

edited by toddr

Loading

atoomic commented Jan 31, 2022

toddr commented Jan 31, 2022

Only show files within the directory #118

Only show files within the directory #118

Comments

xsawyerx commented Jan 31, 2022 • edited by toddr Loading

atoomic commented Jan 31, 2022

toddr commented Jan 31, 2022

xsawyerx commented Jan 31, 2022 •

edited by toddr

Loading