remove perlcritic -5 warnings

[mishin]

Hi, Guys, super project,
so, I think 1 as last value of module is criitcal
and return for function

[karenetheridge]

These all seem like silly and unnecessary changes. A module only needs to return a true value; it doesn't need to be 1.

[charsbar]

Thanks for requesting but I agree with Karen. Won't merge this.

[mishin]

Well, guys, I agree with you, it's very little bound, but ok.
I just want to know how calculate
package_version_matches_dist_version
and
is_prereq
for http://cpants.cpanauthors.org/author/MISHIN

[mishin]

thanks

[charsbar]

@mishin, forget about is_prereq, which is something you can't make green by yourself (and thus, should be marked and shown differently from other metrics, maybe).

As for the package_version_matches_dist_version, it is because your version number is not safe and may lose important bit while calculating. See the following.

perl -E 'say version->new("5.18.1.0.35")->numify'  # 5.018001000033
perl -E 'say version->new("5.018001000033")'       # 5.018001000033
perl -E 'say version->new(5.018001000033)'         # 5.018001 (oops)

So, it was a bug in Module::CPANTS::SiteKwalitee, and was fixed by cpants/Module-CPANTS-SiteKwalitee@7dd3aa6 (thanks!)