Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added properly working Github Action #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Hukasx0
Copy link

@Hukasx0 Hukasx0 commented Oct 4, 2023

No description provided.

@cpcdoy
Copy link
Owner

cpcdoy commented Oct 4, 2023

Thank you for the contribution, wanted to get back to setting this up but didn't get any time recently!

@cpcdoy
Copy link
Owner

cpcdoy commented Oct 4, 2023

Ideally, we'd want the CI to download the models in a models directory and run cargo test

@Hukasx0
Copy link
Author

Hukasx0 commented Oct 5, 2023

Ideally, we'd want the CI to download the models in a models directory and run cargo test

I didn't really know how to do it (where to get these models). I did as much as I could. If you want, you can modify the code so that the tests are performed correctly, or you can provide more information and I can try to fix it somehow.

@cpcdoy
Copy link
Owner

cpcdoy commented Oct 17, 2023

I won't have much time on my end to work on this for at least a few days or a week, but if you want to get this done before, there are instructions in the README on how to download the models and on running the conversion script. There is also a Docker image that shows how to convert the models. Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants