Skip to content

Commit

Permalink
docs: add comment about why the replacement strategies are necessary
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud committed Nov 26, 2021
1 parent c9370cd commit f98e41c
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions protoletariat/fdsetgen.py
Expand Up @@ -46,6 +46,10 @@ def fix_imports(
fd_name = _remove_proto_suffix(fd.name)
rewriters[fd_name] = rewriter = ChainedImportRewriter(
ASTImportRewriter(),
# FIXME: mypy_protoc generates broken pyi files for long lines
# StringReplaceImportRewriter is an architectural workaround
# to allow replacement of strings so that the pyis might be able
# to work
StringReplaceImportRewriter(),
)
# services live outside of the corresponding generated Python
Expand Down

0 comments on commit f98e41c

Please sign in to comment.