Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): add Tips #60

Merged
merged 6 commits into from Sep 25, 2020
Merged

feat(docs): add Tips #60

merged 6 commits into from Sep 25, 2020

Conversation

ouuan
Copy link
Member

@ouuan ouuan commented Sep 20, 2020

No description provided.

@pull-assistant
Copy link

pull-assistant bot commented Sep 20, 2020 •
edited

Score: 0.96

Best reviewed: commit by commit

Optimal code review plan

     feat: add Tips

     style: use <kbd> for shortcuts

     fix: fix header level

     feat(tips): add tips for handling SIGINT and SIGHUP

     fix: use "UNIX-like" instead of "Linux-like"

     feat: try restarting CP Editor after changing the UI style

Powered by Pull Assistant. Last update bae6d07 ... f3e0a52. Read the comment docs.

@render
Copy link

render bot commented Sep 20, 2020

Your Render PR Server URL is https://cpeditor-github-io-pr-60.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-btjc5l8ti7j6ur3ugev0.

@ouuan ouuan changed the title feat: add Tips feat(docs): add Tips Sep 20, 2020
@coder3101
Copy link
Member

Add a tip in UI style and you can mention "If you encounter UI style issues after changing UI Style. please restart the application".

I have seen that when I switch to Fusion Dark style then back to Default. The messagelogger font color is grey-ish not black as it should be. It could be a Qt Bug as you mentioned, so you should add this as inline tip for that action.

coder3101
coder3101 previously approved these changes Sep 25, 2020
View reviewed changes
content/en/docs/Tips/_index.md Outdated

CP Editor supports some command-line options, run `cpeditor --help` for more information.

On Windows, it's better to use Linux-like shells like git bash.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more generic term would be UNIX-like.

@ouuan ouuan merged commit 946abec into hugo Sep 25, 2020
@ouuan ouuan deleted the tips branch September 25, 2020 13:42
github-actions bot pushed a commit that referenced this pull request Sep 25, 2020
@ouuan
feat(docs): add Tips (#60)
579a00e 
* feat: add Tips

* style: use <kbd> for shortcuts

* fix: fix header level

* feat(tips): add tips for handling SIGINT and SIGHUP

* fix: use "UNIX-like" instead of "Linux-like"

* feat: try restarting CP Editor after changing the UI style 946abec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coder3101 coder3101 coder3101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ouuan @coder3101