Skip to content

Commit

Permalink
Performance improvements on diagonistics and fix issue where companio…
Browse files Browse the repository at this point in the history
…n error log was not displayed
  • Loading branch information
coder3101 committed Jan 9, 2020
1 parent 83aa681 commit 3d1e515
Show file tree
Hide file tree
Showing 10 changed files with 57 additions and 14 deletions.
4 changes: 3 additions & 1 deletion CMakeLists.txt
@@ -1,6 +1,6 @@
cmake_minimum_required(VERSION 3.5)

project(CPEditor LANGUAGES CXX VERSION 4.0.3)
project(CPEditor LANGUAGES CXX VERSION 4.1.0)

set(CMAKE_INCLUDE_CURRENT_DIR ON)

Expand Down Expand Up @@ -63,6 +63,8 @@ add_executable(CPEditor
ui/preferencewindow.ui
include/EditorTheme.hpp
src/editortheme.cpp
include/cftools.hpp
src/cftools.cpp

${CMAKE_BINARY_DIR}/generated/version.hpp

Expand Down
1 change: 1 addition & 0 deletions include/CompanionServer.hpp
Expand Up @@ -49,6 +49,7 @@ class CompanionServer : public QObject
public:
CompanionServer(int port);
void setMessageLogger(MessageLogger *log);
void checkServer();

void updatePort(int port);
~CompanionServer();
Expand Down
1 change: 1 addition & 0 deletions include/appwindow.hpp
Expand Up @@ -95,6 +95,7 @@ class AppWindow : public QMainWindow
void allocate();
void applySettings();
void saveSettings();
bool diagonistics;
QVector<QShortcut *> hotkeyObjects;
void maybeSetHotkeys();
};
Expand Down
22 changes: 22 additions & 0 deletions include/cftools.hpp
@@ -0,0 +1,22 @@
#ifndef CFTOOLS_HPP
#define CFTOOLS_HPP

#include <QProcess>
namespace Network
{
class CFTools
{
public:
CFTools();

void submit();
void killProcess();

static bool check();
~CFTools();
private:
QProcess* cftool = nullptr;

};
}
#endif // CFTOOLS_HPP
2 changes: 1 addition & 1 deletion include/mainwindow.hpp
Expand Up @@ -68,7 +68,7 @@ class MainWindow : public QMainWindow
void maybeLoadTemplate();

void setLanguage(QString lang);
void setSettingsData(Settings::SettingsData data);
void setSettingsData(Settings::SettingsData data, bool);

MessageLogger *getLogger();
QFile *getOpenFile();
Expand Down
8 changes: 6 additions & 2 deletions src/CompanionServer.cpp
Expand Up @@ -19,6 +19,10 @@ CompanionServer::CompanionServer(int port)
void CompanionServer::setMessageLogger(MessageLogger *log)
{
this->log = log;
}

void CompanionServer::checkServer()
{
if (log != nullptr)
{

Expand All @@ -29,8 +33,8 @@ void CompanionServer::setMessageLogger(MessageLogger *log)
}
else
{
log->info("Companion", "Listening for request on " + server->serverAddress().toString().toStdString() +
std::to_string(server->serverPort()));
log->info("Companion", "Listening for requests on " + server->serverAddress().toString().toStdString() + ":" +
std::to_string(server->serverPort()));
}
}
}
Expand Down
10 changes: 7 additions & 3 deletions src/appwindow.cpp
Expand Up @@ -377,7 +377,11 @@ void AppWindow::onTabChanged(int index)
activeLogger = tmp->getLogger();
server->setMessageLogger(activeLogger);

tmp->setSettingsData(settingManager->toData());
if(settingManager->isCompetitiveCompanionActive())
server->checkServer();

tmp->setSettingsData(settingManager->toData(), diagonistics);
diagonistics = false;
tmp->maybeLoadTemplate();

if (!splitterState.isEmpty())
Expand Down Expand Up @@ -441,14 +445,14 @@ void AppWindow::onSettingsApplied()
if (settingManager->isCompetitiveCompanionActive())
companionEditorConnections =
connect(server, &Network::CompanionServer::onRequestArrived, this, &AppWindow::onIncomingCompanionRequest);

diagonistics = true;
onTabChanged(ui->tabWidget->currentIndex());
}

void AppWindow::onIncomingCompanionRequest(Network::CompanionData data)
{
auto newTab = new MainWindow(ui->tabWidget->currentIndex(), "");
newTab->setSettingsData(settingManager->toData());
newTab->setSettingsData(settingManager->toData(), true);
newTab->maybeLoadTemplate();
newTab->applyCompanion(data);
ui->tabWidget->addTab(newTab, newTab->fileName());
Expand Down
10 changes: 10 additions & 0 deletions src/cftools.cpp
@@ -0,0 +1,10 @@
#include "cftools.hpp"

namespace Network {

CFTools::CFTools()
{

}

}
11 changes: 5 additions & 6 deletions src/mainwindow.cc
Expand Up @@ -340,7 +340,7 @@ void MainWindow::applyCompanion(Network::CompanionData data)
}
onTextChangedTriggered();
}
void MainWindow::setSettingsData(Settings::SettingsData data)
void MainWindow::setSettingsData(Settings::SettingsData data, bool shouldPerformDigonistic)
{
this->data = data;
formatter->updateCommand(data.formatCommand);
Expand Down Expand Up @@ -369,17 +369,17 @@ void MainWindow::setSettingsData(Settings::SettingsData data)

if(data.viewMode == Settings::ViewMode::FULL_EDITOR)
{
ui->splitter->restoreState("");
ui->splitter->restoreGeometry("");
ui->splitter->setSizes({1,0});
}
else if(data.viewMode == Settings::ViewMode::FULL_IO)
{
ui->splitter->restoreState("");
ui->splitter->restoreGeometry("");
ui->splitter->setSizes({0,1});
}
else
{
ui->splitter->restoreState("");
ui->splitter->restoreGeometry("");
ui->splitter->setSizes({1,1});
}

Expand Down Expand Up @@ -414,9 +414,8 @@ void MainWindow::setSettingsData(Settings::SettingsData data)
if (!isLanguageSet)
{
setLanguage(data.defaultLanguage);
isLanguageSet = true;
}
else
if(shouldPerformDigonistic)
performCoreDiagonistics();
}
void MainWindow::save(bool force)
Expand Down
2 changes: 1 addition & 1 deletion win-setup.iss
Expand Up @@ -2,7 +2,7 @@
; SEE THE DOCUMENTATION FOR DETAILS ON CREATING INNO SETUP SCRIPT FILES!

#define MyAppName "CP Editor"
#define MyAppVersion "4.0.3"
#define MyAppVersion "4.1.0"
#define MyAppPublisher "Ashar Khan <coder3101>"
#define MyAppURL "https://github.com/coder3101/cp-editor2"
#define MyAppExeName "CPEditor.exe"
Expand Down

0 comments on commit 3d1e515

Please sign in to comment.