Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memorize the size of the window #22

Closed
ouuan opened this issue Dec 6, 2019 · 7 comments
Closed

Memorize the size of the window #22

ouuan opened this issue Dec 6, 2019 · 7 comments
Labels
enhancement New feature or request linux Linux related Issues low_priority This label is for issues that have less prority for now. macOS MacOS related Issue windows Affecting Windows

Comments

@ouuan
Copy link
Member

ouuan commented Dec 6, 2019

Is your feature request related to a problem? Please describe.

Every time I open the CP Editor, its size is the same, even I changed its size last time.

Describe the solution you'd like

When I open the editor, its size should be the same as I closed it last time.

Describe alternatives you've considered

N/A

Additional context

N/A

@caretaker-claire
Copy link

Hi ouuan
Thanks for Opening a new Issue here. I will also thank you for strictly following the Issue Templates.
I will add an appropriate tag to your Issue.

Have Patience, One of our Cool Contributors will help you soon.

@caretaker-claire caretaker-claire bot added the enhancement New feature or request label Dec 6, 2019
@coder3101
Copy link
Member

By size you mean. Windows Size? I can make it open maximized by default. Will that be Okay?

@coder3101 coder3101 added confirmation_required Strange issues are marked with this label. If more people confirm. It may gain priority linux Linux related Issues low_priority This label is for issues that have less prority for now. macOS MacOS related Issue windows Affecting Windows labels Dec 6, 2019
@ouuan
Copy link
Member Author

ouuan commented Dec 6, 2019

By size you mean. Windows Size? I can make it open maximized by default. Will that be Okay?

It's okay for me, because I usually use full window. But I think memorizing the size of the last use would be good for everyone. Many other editors/IDEs have this function.

@coder3101 coder3101 removed the confirmation_required Strange issues are marked with this label. If more people confirm. It may gain priority label Dec 6, 2019
coder3101 added a commit that referenced this issue Dec 6, 2019
@coder3101
Copy link
Member

In a few minute a release will be up, Which fixes this issue. If it doesn't fixes the issue you can re-open this issue.

@ouuan
Copy link
Member Author

ouuan commented Dec 6, 2019

Full size and not full size should be treated separately:

  1. Open the editor, now it's not full size, but with size x.
  2. Click "full size" button, now it's full size.
  3. Close the editor.
  4. Open the editor, the editor should be full size.
  5. Click "restore" button, now it's not full size, but with size x (which is mentioned in step 1).
  6. Change the size to y.
  7. Close the editor.
  8. Open the editor, the size should be y.

In the version 2.0.2, if you turn to full size in the last session, next time it will be not full size, but the size is big so that it looks like it's full size.

(I'm not so sure about the English expression of "not full size" and "restore", also there may be some grammar mistakes, hope you can understand.)

@coder3101
Copy link
Member

The editor opens in Full screen but not Maximised. I am aware of this but this does the work done for a hot fix. In some other future release the issue of Maximised and Full screen will be solved.

@coder3101
Copy link
Member

Fixed in last commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request linux Linux related Issues low_priority This label is for issues that have less prority for now. macOS MacOS related Issue windows Affecting Windows
Projects
None yet
Development

No branches or pull requests

2 participants