Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open a window when checking for updates #361

Closed
StudyingFather opened this issue May 17, 2020 · 2 comments · Fixed by #370
Closed

open a window when checking for updates #361

StudyingFather opened this issue May 17, 2020 · 2 comments · Fixed by #370
Assignees
@coder3101
Labels
enhancement New feature or request medium_priority Medium Priority Issues

Comments

@StudyingFather
Copy link
Member

Is your feature request related to a problem? Please describe.

When I click "check for updates", all I can do is to wait for results.

If I can not connect with the Github server, I can not get any response about this situation.

Describe the solution you'd like

  1. Open a window when checking for updates so that I know the update checker is working. And if possible I can close the window to terminate the update check.
  2. Add a timeout. If the checker do not get response within the timeout, show the error message.

Describe alternatives you've considered

Additional context
@StudyingFather StudyingFather added the enhancement New feature or request label May 17, 2020
@coder3101 coder3101 self-assigned this May 17, 2020
@coder3101
Copy link
Member

In addition to it we can also show changelog of new update as well.

@coder3101 coder3101 added the medium_priority Medium Priority Issues label May 17, 2020
@coder3101
Copy link
Member

I am working on this. Just to let others not work on the same Issue.

coder3101 added a commit that referenced this issue May 23, 2020
@coder3101
New App Updater, fixes #361
8adff26 
Telemetry/UpdateChecker only checks for new updates and sends a signal
with information weather update is available or not. Widgets and custom
dialogs now show chagelogs and direct download button depending upon OS.

It also provides some finer control over the update checker, so user can
see indeterminant progress of the update check and even cancel the
check. The Update UI has been made much cleaner and so has been the
code.

The changelog view supports full markdown formating, with the exeception
that mardown literals like `#` are also shown.
@coder3101 coder3101 mentioned this issue May 23, 2020
Merged
19 tasks
@coder3101 coder3101 linked a pull request May 23, 2020 that will close this issue
feat: New App Updater Dialog Window #370
Merged
19 tasks
ouuan added a commit that referenced this issue May 28, 2020
@coder3101 @ouuan
feat: New update checker (#370)
77563c3 
* New App Updater, fixes #361

Telemetry/UpdateChecker only checks for new updates and sends a signal
with information weather update is available or not. Widgets and custom
dialogs now show chagelogs and direct download button depending upon OS.

It also provides some finer control over the update checker, so user can
see indeterminant progress of the update check and even cancel the
check. The Update UI has been made much cleaner and so has been the
code.

The changelog view supports full markdown formating, with the exeception
that mardown literals like `#` are also shown.

* Revert cmake version to 6.5.0

* Replaces tabs with spaces and add Qt5::Widgets link

* Fix(CI): Linux case sensitive include

* refactor: Improve the update checker and require Qt ^5.14

1. Use the Markdown of QTextEdit introduced in Qt 5.14 instead of the
   markdown_highlighter, hence require Qt ^5.14.
2. Many improvements. It's hard to list all of them, and it's better
   to read the codes.

* feat: show on top instead of raise

* feat(UpdateChecker): show more changelog when update is available

1. The update checker is refactored.
2. Now more changelog is shown. The changelog of a version is shown,
   iff the following are satisfied:
   - This version is valid (i.e. three integers separated by a dot).
   - This version is strictly higher than the current version.
   - One of:
     - This version is the first patch version of a minor version.
     - This version is of the same minor version as the latest release.

Perhaps some other changes are also introduced with the refactor.

Co-authored-by: Yufan You <ouuansteve@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coder3101 coder3101

Labels
enhancement New feature or request medium_priority Medium Priority Issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: New App Updater Dialog Window cpeditor/cpeditor
2 participants
@coder3101 @StudyingFather