Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to change the color of messages shown in the message logger #521

Closed
sahilkhan03 opened this issue Jul 24, 2020 · 5 comments · Fixed by #1247
Closed

Option to change the color of messages shown in the message logger #521

sahilkhan03 opened this issue Jul 24, 2020 · 5 comments · Fixed by #1247
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Harder than good first issues but not too hard for newcomers, and not assigned to any maintainer medium_priority Medium Priority Issues

Comments

@sahilkhan03
Copy link

I find red color irritating and difficult to read, unfortunately, by default all the variables printed in cerr are shown red in console. So it would be better if there is an option to select the color of messages
@sahilkhan03 sahilkhan03 added the enhancement New feature or request label Jul 24, 2020
@ouuan ouuan changed the title change color of messages shown in console Option to change the color of messages shown in the message logger Jul 24, 2020
@ouuan ouuan added good first issue Good for newcomers help wanted Harder than good first issues but not too hard for newcomers, and not assigned to any maintainer medium_priority Medium Priority Issues labels Jul 24, 2020
@ouuan
Copy link
Member

ouuan commented Jul 26, 2020

@allcontributors add @sahilkhan03 as a contributor for ideas.

@allcontributors allcontributors bot mentioned this issue Jul 26, 2020
Merged
@allcontributors
Copy link
Contributor

@ouuan

I've put up a pull request to add @sahilkhan03! 🎉

@ouuan
Copy link
Member

ouuan commented Jul 30, 2020

Now there are some places using a color name instead of warn, info, error, for example, when showing an accepted verdict. We should add a function accepted and make the function using the color name private.

@coder3101
Copy link
Member

Agreed, and there can be a setting tab titled "Colors" under appearance. Whatever is now in appearance should go under "Appearance->General".

brun0-matheus added a commit to brun0-matheus/cpeditor that referenced this issue Nov 2, 2023
@brun0-matheus
feat: Add menu option to choose message logger colors
c19829a 
Add two new settings: "Error Message Color" and "Warn Message Color".
These settings are located at Appeareance -> General, and have a
combo box to select the colors, using default Qt Colors names
(see https://doc.qt.io/qt-5/stylesheet-reference.html#color).

Addresses the issue cpeditor#521
brun0-matheus added a commit to brun0-matheus/cpeditor that referenced this issue Nov 2, 2023
@brun0-matheus
feat: Use user-specified colors on message logger
ea7dcfc 
Use the settings "Error Message Color" and "Warn Message Color"
to retrieve the error/warning colors instead of using hardcoded
ones.

Addresses issue cpeditor#521
@brun0-matheus brun0-matheus mentioned this issue Nov 2, 2023
Merged
4 tasks
@brun0-matheus
Copy link
Contributor

I've looked into this issue and made a pull request (that I think closes it). It's my first contribution, so if I've made something wrong, warn me.

coder3101 added a commit that referenced this issue Dec 16, 2023
@brun0-matheus @coder3101
feat: edit error/warning messages color of message logger (#1247)
42f0532 
* feat: Add menu option to choose message logger colors

Add two new settings: "Error Message Color" and "Warn Message Color".
These settings are located at Appeareance -> General, and have a
combo box to select the colors, using default Qt Colors names
(see https://doc.qt.io/qt-5/stylesheet-reference.html#color).

Addresses the issue #521

* feat: Use user-specified colors on message logger

Use the settings "Error Message Color" and "Warn Message Color"
to retrieve the error/warning colors instead of using hardcoded
ones.

Addresses issue #521

* Update CHANGELOG (error/warning color)

Add to changelog the option to choose the error/warning message
color of message logger.

* Update translation files (for error/warning colors settings)

Update the translation files to address the texts of the two
new settings "Error Message Color" and "Warn Message Color"

---------

Co-authored-by: Ashar <coder3101@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Harder than good first issues but not too hard for newcomers, and not assigned to any maintainer medium_priority Medium Priority Issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: edit error/warning messages color of message logger brun0-matheus/cpeditor
4 participants
@coder3101 @ouuan @brun0-matheus @sahilkhan03