Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undo a Replace All in a single step #1037

Merged
merged 2 commits into from Jan 14, 2022
Merged

fix: undo a Replace All in a single step #1037

merged 2 commits into from Jan 14, 2022

Conversation

ouuan
Copy link
Member

@ouuan ouuan commented Jan 13, 2022 •
edited

Description

Undo a Replace All in a single step.

Related Issues / Pull Requests

This fixes #1036.

How Has This Been Tested?

On Arch Linux.

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

@ouuan ouuan enabled auto-merge (squash) January 13, 2022 14:03
@ouuan ouuan requested review from a team, coder3101, neko-para and swiftqwq and removed request for a team January 14, 2022 10:49
@ouuan ouuan merged commit c05fe54 into master Jan 14, 2022
@ouuan ouuan deleted the replace-all-single-step branch January 14, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coder3101 coder3101 coder3101 approved these changes

@neko-para neko-para Awaiting requested review from neko-para neko-para was automatically assigned from cpeditor/developers

@swiftqwq swiftqwq Awaiting requested review from swiftqwq swiftqwq was automatically assigned from cpeditor/developers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undoing a Find & Replace All should be done in a single step
2 participants
@ouuan @coder3101