Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Spanish translations #1131

Merged
merged 5 commits into from Dec 23, 2022
Merged

feat: add Spanish translations #1131

merged 5 commits into from Dec 23, 2022

Conversation

D4NZ-jpg
Copy link
Member

@D4NZ-jpg D4NZ-jpg commented Dec 22, 2022

Description

Added Spanish translations, and the files required for it

Related Issues / Pull Requests

This closes #1130

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Checklist

  • If the key of a setting is changed, the old attribute is updated or it is resolved in SettingsUpdater.
  • If there are changes of the text displayed in the UI, they are wrapped in tr() or QCoreApplication::translate().
  • If needed, I have opened a pull request or an issue to update the documentation.
  • If these changes are notable, they are documented in CHANGELOG.md.

Additional text

@ouuan
Copy link
Member

ouuan commented Dec 23, 2022

Looks good to me. You can ask some friends to review it or I can also merge it right now.

@coder3101
Copy link
Member

Looks good to me. You can ask some friends to review it or I can also merge it right now.

I think we can merge it, improvements can be done later by other Spanish users.

@D4NZ-jpg
Copy link
Member Author

A friend has already partially reviewed the translations, but in the future, I would like to ask a few more friends to check it more thoroughly. This may take some time, but I think it is ready to be merged for now, and as @coder3101 said, improvements could also be done by other users later on.

@ouuan ouuan merged commit 0bfcdb9 into cpeditor:master Dec 23, 2022
@D4NZ-jpg
Copy link
Member Author

@all-contributors please add @D4NZ-jpg for translation

@allcontributors
Copy link
Contributor

@D4NZ-jpg

I've put up a pull request to add @D4NZ-jpg! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spanish translation
3 participants