feat: Gracefully exit on Signals

[coder3101]

Description

Adds Signal handler with help of QCtrlControl

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Type of changes

• Bug fix (changes which fix an issue)
• New feature (changes which add functionality)
• Documentation (changes which modify the documentation only)
• Style change (changes which do not affect the meaning of the code: code formatting, etc.)
• Refactor (changes which affect the meaning of the code but neither fix a bug nor add a feature)
• Performance improve (changes which improve performance)
• Test (changes which add tests)
• Build (Changes that affect the build system or external dependencies)
• CI (changes to CI configuration files and scripts)
• Chore (changes which do not belong to any type above)
• Revert (revert previous changes)

Checklist

• I have read the CONTRIBUTING document.
• I have tested these changes locally, and this fixes the bug/the new feature behaves as the expectation.
• I have used clang-format-9 and .clang-format file in the root directory to format my codes.
• The settings file in the old version can be used in the new version after this change.
• These changes only fix a single bug/introduces a single feature. (Otherwise, open multiple Pull Requests instead, unless these bugs/features are closely related.)
• The commit messages are clear and detailed. (Otherwise, use git reset and commit again, or use git rebase -i and git commit --amend to modify the commit messages.)
• These changes don't remove an existing feature. (Otherwise, add an option to disable this feature instead, unless it's necessary to remove this feature.)
• I have documented these changes in CHANGELOG.md, or these changes are not notable.

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan (1 warning)

     Add QCtrlSignals as dependency for Signal Handling

Add initial support for signal handling

...c/Settings/SettingsManager.cpp 50% changes removed in style: Format codes ...

src/appwindow.hpp 60% changes removed in style: Format codes ...

     style: Format codes (#326)

     feat: Update handling signals

     feat: always force-close on Windows

     Use settings.json from handle-signal branch

Powered by Pull Assistant. Last update e454f99 ... 0d0aa9a. Read the comment docs.

[coder3101]

I have left the handing signal with a comment on what should be expected behaviour or what could be better than this as per your wish. I have ported the changes to appwindow and other helper API from #268 into this.

I also confirm that now, I am able to exit gracefully (with hot exit enabled) and that this library works fine on my windows.

[ouuan]

Now it doesn't catch SIGHUP, which is sent on Linux when closing the terminal where the application was started 🤔. However, I saw SIGHUP in qctrlsignalhandler_unix.cpp, we may need to find out how to catch it later.

And, without this:

cpeditor/src/Application.cpp

Line 255 in 68140a7

emit requestToExit();

, the application won't be killed after receiving SIGTERM during the progress dialog.

[ouuan]

Please test the latest commit first.

[coder3101]

Please test the latest commit first.

It still works on my Windows but when Hotexit is not enabled SIGINT opens the dialog box to ask for saving changes, and same with killing from task manager.

If it will pop open the closeConfirm dialog what good it is? I thought application would exit normally and in next launch show a dialog "Unexpected close, want to restart?"

I have not still ran this commit, will confirm this behaviour in 5-6 hours, I tested locally by putting exact code as you have for signal handling now, (copy pasted old handling code) and found this behaviour during development of this PR

[ouuan]

If it will pop open the closeConfirm dialog what good it is? I thought application would exit normally and in next launch show a dialog "Unexpected close, want to restart?"

I think this is useful on Linux. SIGINT is the same as a normal close, so the user can use Ctrl+C to normally close it. It is strange that the dialog is also showed when it's killed from the Windows task manager, maybe we can treat SIGINT as SIGTERM on Windows.

[ouuan]

I just noticed that d5ea61b has been not working since the new preferences window, because now the settings are saved when normally exiting. After this PR is finished and merged, the feature introduced by that commit will be more useless, so instead of making it work again, we can simply remove it.

[coder3101]

What behaviour you want when SIGTERM and SIGINT is invoked in Windows( from git bash)? I will try to fix it tell me behaviour with Hotexit and without Hotexit?

Note that killing from Task manager sends SIGINT

You work on behaviour for UNIX.