Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(main): open file with unicode in path #37

Merged
merged 1 commit into from
Dec 13, 2019

Conversation

ouuan
Copy link
Member

@ouuan ouuan commented Dec 13, 2019

In the old version, you can't open a file with Unicode in its path (Ctrl+O works well, but opening by the command-line argument doesn't). This PR fixes it.

@caretaker-claire
Copy link

Hi ouuan
Thank you for your contribution to cp-editor2. I will request a review from one of the contributor. Once they approves and all CI checks passes, I will merge your Pull Request.

@coder3101 coder3101 merged commit 7f97839 into cpeditor:master Dec 13, 2019
@ouuan ouuan deleted the fix-unicode-path branch December 13, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants