Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mainwindow): implement isVerdictPass for diff #43

Merged
merged 1 commit into from
Dec 13, 2019
Merged

fix(mainwindow): implement isVerdictPass for diff #43

merged 1 commit into from
Dec 13, 2019

Conversation

ouuan
Copy link
Member

@ouuan ouuan commented Dec 13, 2019

fixes #38

This function ignores whitespaces at the back of a line and lines consisted of only whitespaces at the bottom.

@caretaker-claire
Copy link

Hi ouuan
Thank you for your contribution to cp-editor2. I will request a review from one of the contributor. Once they approves and all CI checks passes, I will merge your Pull Request.

@coder3101 coder3101 merged commit 037ad80 into cpeditor:master Dec 13, 2019
@ouuan ouuan deleted the fix-diff branch December 13, 2019 11:51
@ouuan ouuan mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coder3101 coder3101 coder3101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use testlib.h to check the verdicts
2 participants
@ouuan @coder3101