Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mainwindow): update save as #48

Merged
merged 1 commit into from
Dec 15, 2019
Merged

fix(mainwindow): update save as #48

merged 1 commit into from
Dec 15, 2019

Conversation

ouuan
Copy link
Member

@ouuan ouuan commented Dec 15, 2019

  1. fix the bug of saving a file as itself.
  2. Use saveFile() for save as, more code reuse.
  3. change openFile to the file saved as, which is the same as many other editors/IDEs.

@ouuan
fix(mainwindow): update save as
8afbc92 
1. fix the bug of saving a file as itself.
2. Use saveFile() for save as, more code reuse.
3. change openFile to the file saved as, which is the same as many other editors/IDEs.
@caretaker-claire
Copy link

Hi ouuan
Thank you for your contribution to cp-editor2. I will request a review from one of the contributor. Once they approves and all CI checks passes, I will merge your Pull Request.

@coder3101
Copy link
Member

I am adding CI so that AppImage issue with Linux could be solved. Meanwhile, False Build fails are expected!

@coder3101 coder3101 merged commit 78cbe09 into cpeditor:master Dec 15, 2019
@ouuan ouuan deleted the save-as branch December 15, 2019 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coder3101 coder3101 coder3101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ouuan @coder3101