Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add download link for Chinese users #54

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Conversation

ouuan
Copy link
Member

@ouuan ouuan commented Dec 16, 2019

Downloading on Github can be extremely slow (below 10KiB/s) in Mainland China, this link may be useful for them.

Downloading on Github can be extremely slow (below 10KiB/s) in Mainland China, this link may be useful for them.
@caretaker-claire
Copy link

Hi ouuan
Thank you for your contribution to cp-editor2. I will request a review from one of the contributor. Once they approves and all CI checks passes, I will merge your Pull Request.

@coder3101
Copy link
Member

So is it a mirror?

@ouuan
Copy link
Member Author

ouuan commented Dec 16, 2019

No, it's uploaded by myself.

@coder3101
Copy link
Member

So, every time a new release comes! This url will change? You must gaurantee that the binary in the above url will be latest always!

@ouuan
Copy link
Member Author

ouuan commented Dec 16, 2019

The URL won't change (it will be still the same after changing the content), but manually upload is required.

@coder3101
Copy link
Member

Okay, then you will have to upload the binaries from releases page as soon as a stable release hits. Should I merge?

@ouuan
Copy link
Member Author

ouuan commented Dec 16, 2019

I'll try to upload it ASAP, or you can register on that website and upload by yourself. What do you think?

@coder3101
Copy link
Member

I am setting Automation tools to do that for me. Anyways! Here is what you can do, keep that link and let user know that the exe downloaded from that place may not be updated. It will be easy for someone, to quickly try it after downloading then if they like they can get the latest version by visiting the release page.

@coder3101 coder3101 merged commit 95bbf34 into cpeditor:master Dec 16, 2019
@ouuan ouuan deleted the patch-1 branch December 16, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants