Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mainwindow.cc): restore save tests setting #58

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

ouuan
Copy link
Member

@ouuan ouuan commented Dec 24, 2019

I think it should be my mistake when using git. I remember this setting is restored when I tested it locally. 馃槩

@caretaker-claire
Copy link

Hi ouuan
Thank you for your contribution to cp-editor2. I will request a review from one of the contributor. Once they approves and all CI checks passes, I will merge your Pull Request.

@coder3101 coder3101 merged commit fc79636 into cpeditor:master Dec 24, 2019
@ouuan ouuan deleted the restore-save-tests branch December 25, 2019 04:38
@ouuan
Copy link
Member Author

ouuan commented Dec 25, 2019

Oh, I was stupid. There was nothing wrong with my use of git. The setting was saved, only the check wasn't restored.

@coder3101
Copy link
Member

I have already released it on 3.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants