Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes about preferencewindow #69

Merged
merged 2 commits into from Jan 8, 2020
Merged

Conversation

ouuan
Copy link
Member

@ouuan ouuan commented Jan 8, 2020

No description provided.

OK: apply & close
Cancel: close only
Apply: apply only

Apply is helpful if the user wants to try a setting to see if it's good or not.
@caretaker-claire
Copy link

Hi ouuan
Thank you for your contribution to cp-editor2. I will request a review from one of the contributor. Once they approves and all CI checks passes, I will merge your Pull Request.

@coder3101 coder3101 merged commit 0488da9 into cpeditor:master Jan 8, 2020
@ouuan ouuan deleted the settings branch January 8, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants