feat(formatter): clang-format update #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi ouuan |
ouuan
force-pushed
the
clang-format
branch
2 times, most recently
from
4727241
to
f411dba
Compare
1. Set clang-format binary instead of set format command. 2. Use `--cursor` argument to keep the cursor after formatting. 3. Format selection only if there is a selection. 4. Set format style in preference window. 5. Add format on save option. 6. Open temporary file for formatting when necessary instead of holding it. 7. Other text changes and minor changes. 8. Modify README.md for these changes.
|
BTW, I think the next release should be 5.1.0 instead of 5.0.2 if it includes this PR. |
|
I will review this and merge it tomorrow. It will surely be 5.1 is this releases |
|
This certainly was a lot of work. Glad for having such contributors. :) |
coder3101
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set clang-format binary instead of set format command.
Use
--cursorargument to keep the cursor after formatting.Format selection only if there is a selection.
Set format style in preference window.
Add format on save option.
Open temporary file for formatting when necessary instead of holding it.
Other text changes and minor changes.
Modify README.md for these changes.
This closes #81 .