Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make file logic like Sublime #97

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

ouuan
Copy link
Member

@ouuan ouuan commented Jan 14, 2020

  1. Open file when necessary instead of holding it.

  2. Watch file changes on disk.

  3. Show complete path when multiple tabs are of the same name.

  4. Change language when saving unsaved files / saving as.

  5. Text changes and other minor changes.

Please test these changes. I think there might be some bugs, especially when handling read/write file fails, and things related to problemURL.

@caretaker-claire
Copy link

Hi ouuan
Thank you for your contribution to cp-editor. I will request a review from one of the contributor. Once they approves and all CI checks passes, I will merge your Pull Request.

1. Open file when necessary instead of holding it.

2. Watch file changes on disk.

3. Show complete path when multiple tabs are of the same name.

4. Change language when saving unsaved files / saving as.

5. Text changes and other minor changes.
@ouuan
Copy link
Member Author

ouuan commented Jan 14, 2020

I'd like to reimplement runner/compiler/cf-tool related with #82 first, then implement #92, for fewer conflicts.

@coder3101
Copy link
Member

Yes you are right, when i started the project i was not very aware of Qt API like QTemporaryFile. But Since now you have discovered it, it surely is nice to get rid of Base::Files because they can in future become a bottleneck and are not very portable. Let's Qt handle all cross platform things.

@coder3101
Copy link
Member

I guess this is work in progress. So I will review it once you ask me to do so.

@ouuan
Copy link
Member Author

ouuan commented Jan 15, 2020

I guess this is work in progress. So I will review it once you ask me to do so.

I can also make a new PR and merge this to it, or work on #82 in this PR. But for a clean commit history, I'd like to have this PR merged first.

@coder3101 coder3101 merged commit 266e236 into cpeditor:master Jan 15, 2020
@ouuan ouuan deleted the sublime-like-file-logic branch January 15, 2020 08:29
coder3101 added a commit that referenced this pull request Jan 15, 2020
coder3101 added a commit that referenced this pull request Jan 15, 2020
coder3101 added a commit that referenced this pull request Jan 15, 2020
coder3101 added a commit that referenced this pull request Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants