Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow triggers to stop tasks #48

Closed
Whathecode opened this issue Aug 12, 2019 · 0 comments · Fixed by #246
Closed

Allow triggers to stop tasks #48

Whathecode opened this issue Aug 12, 2019 · 0 comments · Fixed by #246
Assignees
@Whathecode
Labels
feature New functionality.
Milestone
1.0.0 stable

Comments

@Whathecode
Copy link
Member

Whathecode commented Aug 12, 2019 •
edited
Loading

Right now, it is presumed that triggered tasks are always started. We need to also model the ability to let triggers stop currently running tasks.

Probably, this should not be modeled in Trigger, but in StudyProtocol. This information could be stored in TriggeredTask. We might have to rename addTriggeredTask to startTaskOnTrigger, and add a stopTaskOnTrigger.
@Whathecode Whathecode added the feature New functionality. label Aug 12, 2019
@Whathecode Whathecode added this to the 1.0.0 stable milestone Apr 20, 2021
@Whathecode Whathecode linked a pull request Apr 29, 2021 that will close this issue
Stabilize tasks/measures/sampling types #246
Merged
@Whathecode Whathecode self-assigned this Apr 29, 2021
@pmasulli pmasulli closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Whathecode Whathecode

Labels
feature New functionality.
Projects
None yet
Milestone
1.0.0 stable
Development

Successfully merging a pull request may close this issue.

Stabilize tasks/measures/sampling types cph-cachet/carp.core-kotlin
2 participants
@Whathecode @pmasulli