Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade CARP Data Points to version 1.2 #162

Closed
bardram opened this issue Feb 17, 2021 · 1 comment
Closed

Upgrade CARP Data Points to version 1.2 #162

bardram opened this issue Feb 17, 2021 · 1 comment
Assignees
@bardram
Labels
bug Something isn't working enhancement New feature or request

Comments

@bardram
Copy link
Contributor

bardram commented Feb 17, 2021 •
edited

There are a few issues w. the current implementation of CARPDataPoint:

  • study_id should be study_deployment_id according to v. 1.2
  • the header and body fields in the batch file should be carp_header and carp_body
  • the trigger_id should be set correctly
  • the device_role_name should be set correctly

In general -- there is a need for better alignment of CARP core with CAMS.
@bardram bardram self-assigned this Feb 17, 2021
@bardram bardram added bug Something isn't working enhancement New feature or request labels Feb 17, 2021
@bardram
Copy link
Contributor Author

bardram commented Apr 15, 2021

Released as part of CAMS v. 0.20.0.

@bardram bardram closed this as completed Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bardram bardram

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bardram