Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate authentication library to oidc and refactor authentication code to separate service #374

Merged
merged 24 commits into from
Apr 21, 2024

Conversation

SlimShadyIAm
Copy link
Contributor

@SlimShadyIAm SlimShadyIAm commented Apr 11, 2024

Motivation

Citing cph-cachet/carp_studies_app#272, I have refactored the authentication code in carp_webservices to use the oidc library as it handles token refreshing and authentication more consistently and with a better API.

Closes #370, #371, #372

Changes

This PR makes the following changes:

Breaking changes

  • CarpApp had some properties removed which should now go into CarpAuthProperties, used to configure() CarpAuthService.
  • In addition to configuring CarpService() in clients, CarpAuthService()also needs to be configured.

@SlimShadyIAm SlimShadyIAm marked this pull request as ready for review April 15, 2024 13:21
Copy link
Contributor

@bardram bardram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks super good. Will create a separate branch and try the rest of the unit tests and then release the package.

@bardram bardram merged commit d2b2a5b into main Apr 21, 2024
1 check passed
@SlimShadyIAm SlimShadyIAm deleted the SlimShadyIAm/refactor-authentication-service branch May 20, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment