-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate authentication library to oidc
and refactor authentication code to separate service
#374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bardram
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks super good. Will create a separate branch and try the rest of the unit tests and then release the package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Citing cph-cachet/carp_studies_app#272, I have refactored the authentication code in
carp_webservices
to use theoidc
library as it handles token refreshing and authentication more consistently and with a better API.Closes #370, #371, #372
Changes
This PR makes the following changes:
oidc
for authenticationCarpService
into a separateCarpAuthService
.CarpService
.CarpApp
into a separateCarpAuthProperties
class, which is usde to configureCarpAuthService
.carp_backend
so that it works with the new changes.authenticate()
method if the Login Manager is not initializedBreaking changes
CarpApp
had some properties removed which should now go intoCarpAuthProperties
, used toconfigure()
CarpAuthService
.CarpService()
in clients,CarpAuthService()
also needs to be configured.