Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[health]callToHealthTypes in HelathPlugin.kt calls keyToHealthDataType with wrong key always. #201

Closed
kouchi32 opened this issue Oct 4, 2020 · 3 comments
Labels
bugfix a bug fix

Comments

@kouchi32
Copy link
Contributor

kouchi32 commented Oct 4, 2020

Device / Emulator and OS

Please complete the following information for each phone and/or emulator you're experiencing this bug on:

  • Pixel 3a
  • Android 10

Describe the bug

callToHealthTypes method calls keyToHealthDataType with wrong key that is ArrayList.toString(). ArrayList.toString() returns [WEIGHT] for example.

Expected behavior

  • DataPoints return always empty.

Additional information

There is PR.
#200

@kouchi32 kouchi32 added the bugfix a bug fix label Oct 4, 2020
@kouchi32 kouchi32 changed the title [health]callToHealthTypes method calls keyToHealthDataType with wrong key always. [health]callToHealthTypes in HelathPlugin.kt calls keyToHealthDataType with wrong key always. Oct 5, 2020
@TylerStein
Copy link

+1 applying this fixed an issue where permissions were not being granted on my end, resulting in Google auth errors when retrieving data. Thanks for the fix!

Tested on a Galaxy S8 and a Pixel 3a for the permissions: BODY_FAT_PERCENTAGE, STEPS, HEART_RATE, BODY_TEMPERATURE, BLOOD_GLUCOSE

@thomasnilsson
Copy link
Contributor

Thank you, I will review and merge this.

@thomasnilsson
Copy link
Contributor

Merged in version 2.0.7 :)

thomasnilsson pushed a commit that referenced this issue Oct 10, 2020
thomasnilsson pushed a commit that referenced this issue Oct 10, 2020
hibitness-quan-nguyen2 pushed a commit to hibitness/flutter-plugins that referenced this issue Dec 18, 2023
hibitness-quan-nguyen2 pushed a commit to hibitness/flutter-plugins that referenced this issue Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix a bug fix
Projects
None yet
Development

No branches or pull requests

3 participants