health: bug in requestAuthorization #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the function `requestAuthorization` is invoked multiple times with a list of types containing the type `BODY_MASS_INDEX`, the function tends to incrementally add `HEIGHT` and `WEIGHT` on every invocation. The suggested changes will only add the data types if they are not already present in the input list.
hibitness-quan-nguyen2
pushed a commit
to hibitness/flutter-plugins
that referenced
this pull request
Dec 18, 2023
health: bug in requestAuthorization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
When the function
requestAuthorizationis invoked multiple times with a list of types containing the typeBODY_MASS_INDEX, the function tends to incrementally addHEIGHTandWEIGHTon every invocation. The.toSet().toList()does not seem to remove the duplicates.Proposed solution
Suggested changes will only add the data types if they are not already present in the input list. This avoids the call to
.toSet.toList().