Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activity recognition upgrade #314

Merged
merged 4 commits into from
May 17, 2021
Merged

Activity recognition upgrade #314

merged 4 commits into from
May 17, 2021

Conversation

koenniem
Copy link

This PR features 3 changes:

  1. Fix of issue activity_recognition_flutter 3.0 NullPointer #309, i.e. a null pointer that occurs when running the plugin on API 30.
  2. I replaced the deprecated IntentService and replaced it with a JobIntentService. Consequently, to handle the callback coming from ActivityRecognitionClient.requestActivityUpdates, the PendingIntent instead refers to ActivityRecognizedBroadcastReceiver who then calls ActivityRecognizedService.enqueuework() to handle the intent and extract the activity in the background.
  3. In the same spirit of future proof-ness, I took the liberty of upgrade the target API to 30 as well.

@bardram bardram merged commit 6e732ec into cph-cachet:master May 17, 2021
@bardram
Copy link
Contributor

bardram commented May 17, 2021

Thanks for the PR - have been merged and published as v 4.0.1.

@bardram bardram self-requested a review May 17, 2021 13:42
bardram
bardram reviewed May 17, 2021
View reviewed changes
Copy link
Contributor

@bardram bardram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..

@koenniem koenniem deleted the activity_recognition_upgrade branch August 31, 2021 10:57
hibitness-quan-nguyen2 pushed a commit to hibitness/flutter-plugins that referenced this pull request Dec 18, 2023
@bardram
Merge pull request cph-cachet#314 from koenniem/activity_recognition_…
ea256dc 
…upgrade

Activity recognition upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bardram bardram bardram left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@koenniem @bardram