Allow to record meal data (macro nutrients) #679

biklas7 · 2023-03-01T18:46:15Z

Closes #680

JuanFcoRomero · 2023-03-01T19:17:44Z

Wow! Cool improvement!!! What about read nutrition data? I only can see write that information.

biklas7 · 2023-03-01T22:41:56Z

Wow! Cool improvement!!! What about read nutrition data? I only can see write that information.

Thanks! Didn't add read support on this pr, but it should be pretty straightforward to do it if you want to contribute as well. I think it's only a matter of adding the nutrition types you want to read and mapping then to units and the package should be able to parse them as numeric health values. What do you think?

JuanFcoRomero · 2023-03-02T08:20:08Z

Wow! Cool improvement!!! What about read nutrition data? I only can see write that information.

Thanks! Didn't add read support on this pr, but it should be pretty straightforward to do it if you want to contribute as well. I think it's only a matter of adding the nutrition types you want to read and mapping then to units and the package should be able to parse them as numeric health values. What do you think?

I would love to be able to do that! Unfortunately, I'm a novice programmer and just starting to make my first apps 😔 .

Although I would be very grateful if you could add read and write the whole nutritional topic.

https://developer.apple.com/documentation/healthkit/data_types/nutrition_type_identifiers

biklas7 · 2023-03-02T10:14:11Z

I would love to be able to do that! Unfortunately, I'm a novice programmer and just starting to make my first apps 😔 .

Although I would be very grateful if you could add read and write the whole nutritional topic.

https://developer.apple.com/documentation/healthkit/data_types/nutrition_type_identifiers

Unfortunately, I don't have the time to add more features right now, maybe you should open an issue with that feature request?

Btw the package already supports reading the macronutrients at least on iOS:
https://github.com/cph-cachet/flutter-plugins/blob/master/packages/health/lib/src/data_types.dart#L15-L18

So it should be easy to add support for more types based on the existing code if you have time even if you're a novice... Just take a look at the source code 😉

JuanFcoRomero · 2023-03-02T10:19:14Z

I added it a month ago...

Thank you for that link. I see, so only needs to add the micronutrients.

Thank you for your time!

biklas7 · 2023-03-02T10:31:22Z

@JuanFcoRomero you can see how those were added in the past: 668b419 and that should give you an insight on how to add more.

If you want to also take a look, for Android/Google Fit it works a bit different. There's only one type TYPE_NUTRITION that should give you all the nutrients. Check the docs Read food items eaten and Read Aggregate Daily Nutrition Data.

If you add more don't forget to contribute and open a pull request 👍

JuanFcoRomero · 2023-03-02T16:15:20Z

@JuanFcoRomero you can see how those were added in the past: 668b419 and that should give you an insight on how to add more.

If you want to also take a look, for Android/Google Fit it works a bit different. There's only one type TYPE_NUTRITION that should give you all the nutrients. Check the docs Read food items eaten and Read Aggregate Daily Nutrition Data.

If you add more don't forget to contribute and open a pull request 👍

Thank you so much! I will study the code!

biklas7 · 2023-04-03T10:08:17Z

@MadsVSChristensen sorry to tag you, but just wanted to ask if it's possible to consider this pull request for future releases? Cheers

owjoh · 2023-07-04T10:53:25Z

Any updates on this?

hoffmatteo · 2023-08-31T12:55:48Z

Hello @biklas7,

thank you for the PR!
I have taken the PR and changed it a bit, including adding support for HealthConnect. I will push these changes soon, after which it will be included in the upcoming release.

biklas7 · 2023-09-01T10:06:31Z

Thank you so much @hoffmatteo that's great news! ❤️

I don't want to sound pushy or bite the hand that feeds 😅 but if you could take a look into this one as well #675 it would be awesome! It just adds Insulin data type for iOS (not available for Android) so it's a really small PR and doesn't require too many changes on your side (I think) 🙏

This way we could stop using our outdated fork and finally use this package to it's full potential 👍

hoffmatteo · 2023-09-06T11:28:40Z

@biklas7
Sadly I have bad news, due to circumstances out of our control the release will take at least another week or so, once it is done I will update the PR and request your feedback!

biklas7 · 2023-09-06T16:30:06Z

@hoffmatteo Of course! No rush! Take whatever time you need 👍 The most important thing is that's on the roadmap!

biklas7 · 2023-10-18T08:30:54Z

@hoffmatteo any idea when it's gonna be possible to close this?

biklas7 · 2023-10-18T10:59:48Z

packages/health/ios/Classes/SwiftHealthPlugin.swift

+        }
+
+        if #available(iOS 15.0, *){
+            let meal = HKCorrelation.init(type: HKCorrelationType.init(HKCorrelationTypeIdentifier.food), start: dateFrom, end: dateTo, objects: nutrition, metadata: metadata)


Suggested change

let meal = HKCorrelation.init(type: HKCorrelationType.init(HKCorrelationTypeIdentifier.food), start: dateFrom, end: dateTo, objects: nutrition, metadata: metadata)

let type = HKCorrelationType.correlationType(forIdentifier: HKCorrelationTypeIdentifier.food)!

let meal = HKCorrelation(type: type, start: dateFrom, end: dateTo, objects: nutrition, metadata: metadata)

We discovered a crash on iOS 16 and this fixes it.

@hoffmatteo Please confirm if you don't need this fix. This caused a crash on our fork.

packages/health/ios/Classes/SwiftHealthPlugin.swift

hoffmatteo · 2023-10-23T16:16:09Z

@hoffmatteo any idea when it's gonna be possible to close this?

Hi!
Sorry for the long wait, I had to prioritise some other projects and I had to redo large parts of my earlier work due to IT issues.
I am in the finishing phases of getting it ready, I plan on releasing it this week. I will push my changes these days and look at your suggestions as well!

packages/health/lib/src/data_types.dart

biklas7 · 2023-10-30T16:18:39Z

@hoffmatteo any idea when it's gonna be possible to close this?

Hi! Sorry for the long wait, I had to prioritise some other projects and I had to redo large parts of my earlier work due to IT issues. I am in the finishing phases of getting it ready, I plan on releasing it this week. I will push my changes these days and look at your suggestions as well!

Hi @hoffmatteo glad to hear you're working on this. If you need something let me know! Hope your changes land soon 🤞

hoffmatteo · 2023-10-30T17:11:41Z

@biklas7 I just pushed my changes, sorry for the long wait! Please feel free to review them and let me know your thoughts.

packages/health/android/build.gradle

packages/health/example/android/app/build.gradle

packages/health/lib/src/data_types.dart

biklas7 · 2023-10-31T14:04:21Z

packages/health/ios/Classes/SwiftHealthPlugin.swift

+        }
+
+        if #available(iOS 15.0, *){
+            let meal = HKCorrelation.init(type: HKCorrelationType.init(HKCorrelationTypeIdentifier.food), start: dateFrom, end: dateTo, objects: nutrition, metadata: metadata)


@hoffmatteo Please confirm if you don't need this fix. This caused a crash on our fork.

packages/health/ios/Classes/SwiftHealthPlugin.swift

biklas7 · 2023-10-31T14:08:40Z

@biklas7 I just pushed my changes, sorry for the long wait! Please feel free to review them and let me know your thoughts.

Thanks, everything looks good to me, I just pointed out a few things for you to double-check before merging this, but other than that, it looks good! Thanks for updating the code and working on this feature 👍

António Valente added 6 commits March 1, 2023 16:14

update readme

ff937b3

add nutrition data type

bf73af6

create write meal method channel

6b758e5

allow to write meal to google fit

f854c2d

allow to write meal to apple health

628b031

remove debug print

524bbfe

biklas7 changed the title ~~Allow to record meal data~~ Allow to record meal data (macro nutrients) Mar 2, 2023

hoffmatteo self-assigned this Apr 9, 2023

hoffmatteo mentioned this pull request Sep 6, 2023

[Health 7.0.1] Add Data of Meals or Nutrition and Sleep for Google fit and Health Connect Android #780

Open

hoffmatteo linked an issue Sep 6, 2023 that may be closed by this pull request

[Health 7.0.1] Add Data of Meals or Nutrition and Sleep for Google fit and Health Connect Android #780

Open

Merge branch 'dev-health' into feature/write-meal

1c4e2fc

biklas7 commented Oct 18, 2023

View reviewed changes

[Health] Added Nutrition for HC, added NutritionHealthValue

34f010f

biklas7 commented Oct 30, 2023

View reviewed changes

packages/health/lib/src/data_types.dart Show resolved Hide resolved

[Health] Further improvements to Nutrition

c12481c

biklas7 commented Oct 31, 2023

View reviewed changes

hoffmatteo changed the base branch from master to dev-health November 1, 2023 11:58

[Health] Fixed typo and readme

f5673c1

hoffmatteo merged commit a88ba2e into cph-cachet:dev-health Nov 13, 2023
1 check passed

hoffmatteo mentioned this pull request Nov 13, 2023

Health Release 8.1.0 #832

Merged

biklas7 deleted the feature/write-meal branch January 2, 2024 13:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow to record meal data (macro nutrients) #679

Allow to record meal data (macro nutrients) #679

biklas7 commented Mar 1, 2023 •

edited

JuanFcoRomero commented Mar 1, 2023

biklas7 commented Mar 1, 2023

JuanFcoRomero commented Mar 2, 2023 •

edited

biklas7 commented Mar 2, 2023

JuanFcoRomero commented Mar 2, 2023

biklas7 commented Mar 2, 2023 •

edited

JuanFcoRomero commented Mar 2, 2023

biklas7 commented Apr 3, 2023

owjoh commented Jul 4, 2023

hoffmatteo commented Aug 31, 2023

biklas7 commented Sep 1, 2023

hoffmatteo commented Sep 6, 2023

biklas7 commented Sep 6, 2023

biklas7 commented Oct 18, 2023

biklas7 Oct 18, 2023

biklas7 Oct 18, 2023

biklas7 Oct 31, 2023

hoffmatteo commented Oct 23, 2023 •

edited

biklas7 commented Oct 30, 2023

hoffmatteo commented Oct 30, 2023

biklas7 Oct 31, 2023

biklas7 commented Oct 31, 2023

	let meal = HKCorrelation.init(type: HKCorrelationType.init(HKCorrelationTypeIdentifier.food), start: dateFrom, end: dateTo, objects: nutrition, metadata: metadata)
	let type = HKCorrelationType.correlationType(forIdentifier: HKCorrelationTypeIdentifier.food)!
	let meal = HKCorrelation(type: type, start: dateFrom, end: dateTo, objects: nutrition, metadata: metadata)

Allow to record meal data (macro nutrients) #679

Allow to record meal data (macro nutrients) #679

Conversation

biklas7 commented Mar 1, 2023 • edited

JuanFcoRomero commented Mar 1, 2023

biklas7 commented Mar 1, 2023

JuanFcoRomero commented Mar 2, 2023 • edited

biklas7 commented Mar 2, 2023

JuanFcoRomero commented Mar 2, 2023

biklas7 commented Mar 2, 2023 • edited

JuanFcoRomero commented Mar 2, 2023

biklas7 commented Apr 3, 2023

owjoh commented Jul 4, 2023

hoffmatteo commented Aug 31, 2023

biklas7 commented Sep 1, 2023

hoffmatteo commented Sep 6, 2023

biklas7 commented Sep 6, 2023

biklas7 commented Oct 18, 2023

biklas7 Oct 18, 2023

Choose a reason for hiding this comment

biklas7 Oct 18, 2023

Choose a reason for hiding this comment

biklas7 Oct 31, 2023

Choose a reason for hiding this comment

hoffmatteo commented Oct 23, 2023 • edited

biklas7 commented Oct 30, 2023

hoffmatteo commented Oct 30, 2023

biklas7 Oct 31, 2023

Choose a reason for hiding this comment

biklas7 commented Oct 31, 2023

biklas7 commented Mar 1, 2023 •

edited

JuanFcoRomero commented Mar 2, 2023 •

edited

biklas7 commented Mar 2, 2023 •

edited

hoffmatteo commented Oct 23, 2023 •

edited