Support pagination in health connect #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this looks like an important feature. However, when trying it out using the example app, I end up in an infinite loop, since the pageToken is never null, even though it seems to be an empty string. Did you notice this during testing? |
hoffmatteo
reviewed
Jan 23, 2024
packages/health/android/src/main/kotlin/cachet/plugins/health/HealthPlugin.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues have been reported at #833, indicating that there is a limit on the amount of data that Health Connect can return due to the missing implementation of a pagination system.
This pull request contains a fix for that issue.