Simplify UserDataContext #3896
Merged
Simplify UserDataContext #3896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
we are limited to 1 transaction / second with firebase
|
is this done yet |
|
It is done! Just needs to be tested |
|
This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution! |
|
uuuuhhh nathan? |
|
oops i didn't actually find time to test it, so maybe I'll just merge it LOL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3511
This PR simplifies the implementation of UserDataContext, hopefully making it less buggy and easier to maintain / change in the future.
Future improvements:
loading indicatorsnever mind, I added a warning if user tries to exit before firebase finishes writing; I think this is good enough for now. I can't really think of a good way to show a non-intrusive loading indicatorCheckpoint where we used transactions instead of update doc: e3d9ef7