Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Bazel Support #182

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Drop Bazel Support #182

merged 1 commit into from
Jan 30, 2024

Conversation

cpisciotta
Copy link
Owner

No description provided.

@cpisciotta cpisciotta force-pushed the charles/Bazel branch 3 times, most recently from 617ff2b to bfe401e Compare January 7, 2024 01:32
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5df94fd) 85.83% compared to head (ccfeb2c) 85.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   85.83%   85.83%           
=======================================
  Files          13       13           
  Lines        1842     1842           
=======================================
  Hits         1581     1581           
  Misses        261      261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpisciotta cpisciotta marked this pull request as ready for review January 30, 2024 03:03
@cpisciotta cpisciotta merged commit aba1086 into main Jan 30, 2024
12 checks passed
@cpisciotta cpisciotta deleted the charles/Bazel branch January 30, 2024 03:11
@sanju-naik
Copy link

@cpisciotta Any reason we are dropping Bazel support? We use this library to format our Bazel build output logs.

And also from the code changes it looks like We are dropping support for building this library with Bazel, but formatting bazel build logs using this library is still supported? Is my understanding correct?

@cpisciotta
Copy link
Owner Author

@sanju-naik This PR drops support for building the xcbeautify project itself with Bazel. I don't use the Bazel build system, so I dropped support for it since I'm not maintaining it. As I understand it, this change breaks support for projects using xcbeautify (namely XcbeautifyLib) as an out-of-the-box Bazel dependency. Importantly, I do not intend to drop formatting support for output generated by a Bazel project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants