Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat Warnings as Errors #241

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Treat Warnings as Errors #241

merged 1 commit into from
Jan 16, 2024

Conversation

cpisciotta
Copy link
Owner

On CI, check that the release configuration compiles without compiler warnings.

@cpisciotta cpisciotta linked an issue Jan 16, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7e3df5) 85.83% compared to head (6dae9d0) 85.83%.

❗ Current head 6dae9d0 differs from pull request most recent head ad837ee. Consider uploading reports for the commit ad837ee to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   85.83%   85.83%           
=======================================
  Files          13       13           
  Lines        1842     1843    +1     
=======================================
+ Hits         1581     1582    +1     
  Misses        261      261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpisciotta cpisciotta marked this pull request as ready for review January 16, 2024 00:28
@cpisciotta cpisciotta merged commit 5df94fd into main Jan 16, 2024
12 of 20 checks passed
@cpisciotta cpisciotta deleted the 223-treat-warnings-as-errors branch January 16, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat Warnings as Errors
1 participant