Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Default OutputRendering Implementation #275

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

cpisciotta
Copy link
Owner

@cpisciotta cpisciotta commented Apr 27, 2024

Changes

Move TerminalRenderer code into the OutputRendering extension. When a concrete OutputRendering type doesn't implement a formatting method, it should fall back to a default implementation. Today, the default formatting methods are the ones used and defined by TerminalRenderer.

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 82.50000% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 86.08%. Comparing base (d927949) to head (c2de572).

Files Patch % Lines
...rces/XcbeautifyLib/Renderers/OutputRendering.swift 82.50% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
- Coverage   86.08%   86.08%   -0.01%     
==========================================
  Files          14       14              
  Lines        1567     1545      -22     
==========================================
- Hits         1349     1330      -19     
+ Misses        218      215       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpisciotta cpisciotta merged commit 48e3bed into main Apr 27, 2024
5 of 7 checks passed
@cpisciotta cpisciotta deleted the charles/DefaultOutputRendering branch April 27, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant