Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update term dependency to fix termfile issues #58

Open
jcreigh opened this issue Feb 28, 2018 · 3 comments
Open

Update term dependency to fix termfile issues #58

jcreigh opened this issue Feb 28, 2018 · 3 comments

Comments

@jcreigh
Copy link

jcreigh commented Feb 28, 2018

The new release fixes Stebalien/term#81, which was caused by changes to the termfile format.

The error provided was StringError("terminal missing capability: \'smcup\'"), which lead me to have a very confused look into my terminfo instead of into the libraries. I think it's worth just letting it throw the exception since using a blank TermInfo always just throws an irrelevant message.

rustty/src/core/driver.rs

Lines 124 to 138 in 40d827f

let tinfo = TermInfo::from_env().unwrap_or({
TermInfo {
names: Default::default(),
bools: Default::default(),
numbers: Default::default(),
strings: Default::default(),
}
});
for capname in CAPABILITIES {
if !tinfo.strings.contains_key(*capname) {
return Err(Error::new(ErrorKind::NotFound,
format!("terminal missing capability: '{}'", capname)));
}
}

@lovesegfault
Copy link

My code is currently broken with thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Custom { kind: NotFound, error: StringError("terminal missing capability: \'smcup\'") }', libcore/result.rs:945:5 due to this. It'd be nice if the package was updated

@SamMatzko
Copy link

This error still exists on my system, even though it supposedly was fixed (albeit a long time ago). Could we reopen this issue?

@WhiteBlackGoose
Copy link

Hitting this issue too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants