Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[conv.lval] Improve the note about std::nullptr_t case #2372

Merged
merged 2 commits into from
Nov 26, 2018

Commits on Oct 27, 2018

  1. [conv.lval] Improve the note about std::nullptr_t case

    The meaning of "fetched from memory" is vague, and the two uses of term
    "access" [defns.access] are inappropreate here because
      - it causes undefined behavior to access an inactive member of a
        union, based on the rule of out-of-lifetime object [basic.life]:
        > The program has undefined behavior if:
        >   - the glvalue is used to access the object, or
      - it implies reading the referenced object of std::nullptr_t,
        which is defined to be a side effect for volatile-qualified case.
        [intro.execution]
        > Reading an object designated by a volatile glvalue, ... are all
        > side effects, ...
    k-satoda committed Oct 27, 2018
    Configuration menu
    Copy the full SHA
    f9b9ea9 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2018

  1. [conv.lval] Improve a bit more the note about std::nullptr_t case

    - "read the object" -> "access the object"
      The "read" was derived from the rule at [intro.execution], but it
      didn't fit well here.
    - "the object" -> "the object to which the glvalue refers"
      Make it clear what "the object" refers to.
    
    cplusplus#2372 (review)
    k-satoda committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    45edb77 View commit details
    Browse the repository at this point in the history