Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[istream.unformatted] add missing semi-colon to list item #7117

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[istream.unformatted] add missing semi-colon to list item #7117

merged 1 commit into from
Jul 3, 2024

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Jul 3, 2024

No description provided.

jensmaurer
jensmaurer approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's consistent; I'm not sure I like the thrust.

@jensmaurer jensmaurer merged commit 8bb6363 into cplusplus:main Jul 3, 2024
2 checks passed
@jwakely jwakely deleted the ignore-semi-colon branch July 3, 2024 20:57
@jwakely
Copy link
Member Author

jwakely commented Jul 3, 2024

Yeah it's not great, but we either needed this change, or to remove the semi-colon from the second bullet (and then make them full sentences?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jwakely @jensmaurer