Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor build binaries have different version number from Appveyor version number #299

Closed
mikecopperwhite opened this issue Feb 18, 2017 · 4 comments

Comments

@mikecopperwhite
Copy link
Collaborator

For example Appveyor page https://ci.appveyor.com/project/cplussharp/graph-studio-next/build/0.7.1.6
gives version number as 0.7.1.6 but version number on graphstudionext.exe is 0.7.1.0

Not familiar with Appveyor and whether it's possible for Appveyor to change the resource version number. Perhaps it's just a FAQ if not.

@cplussharp
Copy link
Owner

I think the version number is an Environment Variable during the Appveyor build. I didn't had time to figure out how to include this during build.

mikecopperwhite added a commit that referenced this issue Feb 20, 2017
…gh following Apveyor environment variables as C++ preprocessor and resource compile variables

APPVEYOR_BUILD_VERSION
APPVEYOR_BUILD_NUMBER
Added display of Appveyor build version information in about box as a test.
@mikecopperwhite
Copy link
Collaborator Author

Looks like we have a choice between the full version with dot separators e.g 0.7.1.9 or just the build number e.g. 9

Not sure how to convert dot separated Appveyor version 0.7.1.9 into the comma separated version that will work with the version info resource.

The alternative is to hardcode the first three digits of the version number in VersionNo.h and use the Appveyor build number for the last digit if it's available.

mikecopperwhite added a commit that referenced this issue Feb 20, 2017
…built on Appveyor using Visual Studio 2013 or 2015
@cplussharp
Copy link
Owner

Seems we have worked on the same issue ;)
I have removed the appveyor text and included some conditional comments for the PreprocessorDefinitions in the project files. Because if the envvar APPVEYOR_BUILD_VERSION is not set the definition is empty and I couldn't build localy.

@mikecopperwhite
Copy link
Collaborator Author

Seems fixed now. Not much point in auto generating build number for local builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants