Infer package name and version from URL #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLartians
reviewed
Feb 23, 2021
Comment on lines
+443
to
+446
| list(GET CPM_ARGS_URL 0 firstUrl) | ||
| cpm_package_name_and_ver_from_url(${firstUrl} nameFromUrl verFromUrl) | ||
| # If we fail to obtain name and version from the first URL, we could try other URLs if any. | ||
| # However multiple URLs are expected to be quite rare, so for now we won't bother. |
There was a problem hiding this comment.
TIL FetchContent supports multiple URLs 😄
There was a problem hiding this comment.
I did recently too: https://gitlab.kitware.com/cmake/cmake/-/issues/21847
Co-authored-by: Lars Melchior <TheLartians@users.noreply.github.com>
Also added tests which include a hash algorithm provided We can't document a default until it's confirmed here: https://gitlab.kitware.com/cmake/cmake/-/issues/21859
|
OK. I added an explicit algorithm in README.md. We can document a default once it's confirmed in the CMake issue. |
|
Feature is live in v0.31.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is both for the single-argument syntax, and for the no-name-multi-argument syntax
Closes #208
Closes #181 unmerged. It's superseded by this