Adding simdjson example #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLartians
reviewed
Nov 1, 2023
There was a problem hiding this comment.
Thanks for adding the example for simdjson usage! Two things:
- I see that the example was taken from the simdjson documentation. Do we need to provide the simdjson licence and/or attribution to include the source code in this project?
- Can you format the example using the cmake-format? See our contribution guide for details
Co-authored-by: Lars Melchior <TheLartians@users.noreply.github.com>
I wrote the example so I am the copyright owner, but it is an example... I don't think copyright is a big deal in this instance. |
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds simdjson as an example. (The simdjson library has 17.5k stars on GitHub.)