Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for using the SigC++ library #556

Conversation

ruudbeukema
Copy link

I managed to get the SigC++ library to work with CPM.

Although libsigcplusplus project has a CMakeLists.txt file, the includes and library target name did not end up in a CMake variable right away. That required some fiddling.

I hope you like my contribution and I'm happy to hear if things can be improved.

Copy link
Member

@TheLartians TheLartians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the great example for adding SigC++ with CPM! While it looks like a very useful library at this point I think we should limit what libraries we add to the in-repo official examples to the most popular ones, to keep it tidy and reduce CI time. How about adding the example it to our snippets wiki instead?

@ruudbeukema
Copy link
Author

Hi Lars,

Thanks for your reaction. I've added my snippet to the wiki.

Keep up the good work on CPM!

Cheers, Ruud

@ruudbeukema
Copy link
Author

I'll close this pull request.

@ruudbeukema ruudbeukema deleted the example/add_one_for_libsigcplusplus branch April 22, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants